Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞] Error Boundary Issue #6315

Closed
tzdesign opened this issue May 15, 2024 · 3 comments
Closed

[🐞] Error Boundary Issue #6315

tzdesign opened this issue May 15, 2024 · 3 comments
Assignees
Labels
STATUS-3: solved by V2 This issue is solved by the next major version of Qwik

Comments

@tzdesign
Copy link
Contributor

Which component is affected?

Qwik Runtime

Describe the bug

Using ErrorBoundary (which is not documented) leads to symbol not found error:

image

Reproduction

https://github.com/tzdesign/qwik-error-boundary-issue

Steps to reproduce

pnpm install && pnpm preview

System Info

System:
    OS: macOS 14.5
    CPU: (14) arm64 Apple M3 Max
    Memory: 4.50 GB / 36.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.12.2 - /usr/local/bin/node
    Yarn: 1.22.22 - ~/Library/pnpm/yarn
    npm: 10.5.0 - /usr/local/bin/npm
    pnpm: 9.0.5 - ~/Library/pnpm/pnpm
  Browsers:
    Chrome: 124.0.6367.207
    Edge: 124.0.2478.105
    Safari: 17.5
  npmPackages:
    @builder.io/qwik: ^1.5.4 => 1.5.4 
    @builder.io/qwik-city: ^1.5.4 => 1.5.4 
    typescript: 5.4.5 => 5.4.5 
    undici: * => 6.16.1 
    vite: ^5.2.10 => 5.2.11

Additional Information

It's also odd that qwik has a component ErrorBoundary created by Manu, but does not export it.

If I have time a bit this week, I might write docs about the error boundary.

@tzdesign tzdesign added STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working labels May 15, 2024
@tzdesign
Copy link
Contributor Author

@PatrickJS @wmertens you know if we are able to use useErrorBoundery in the future?

I might listen to qerror for now. I read the code, but I probably don't understand the issue with the log.
Still remains in 1.9.1

@wmertens
Copy link
Member

@Varixo does the errorboundary work in v2?

@gioboa gioboa added STATUS-3: solved by V2 This issue is solved by the next major version of Qwik and removed TYPE: bug Something isn't working STATUS-1: needs triage New issue which needs to be triaged labels Nov 27, 2024
@gioboa
Copy link
Member

gioboa commented Nov 27, 2024

I have this warning in dev mode but it's working fine in dev and preview with v2.

QWIK WARN You are trying to add an event "onError-boundary$" using `useOn` hook, but a node to which you can add an event is not found. Please make sure that the component has a valid element node. 

v2 will be release soon so I marked this issue with STATUS-3: solved by V2, thanks.

@gioboa gioboa closed this as completed Nov 27, 2024
@gioboa gioboa assigned gioboa and unassigned wmertens Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
STATUS-3: solved by V2 This issue is solved by the next major version of Qwik
Projects
None yet
Development

No branches or pull requests

3 participants