Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞] [v2] thrown Promise isn't caught when not awaiting #7442

Open
wmertens opened this issue Mar 20, 2025 · 5 comments
Open

[🐞] [v2] thrown Promise isn't caught when not awaiting #7442

wmertens opened this issue Mar 20, 2025 · 5 comments
Assignees

Comments

@wmertens
Copy link
Member

Which component is affected?

Qwik Runtime

Describe the bug

When the dev calls a qrl without awaiting it, and it needs to be fetched, that will throw a Promise which will be uncaught.

Reproduction

https://qwikdev-build-v2.qwik-8nx.pages.dev/playground/#f=7VbLCsJADPyVpaeFPtCDiGA96EnQg%2FYXLFgonvRU%2Bu9Okq3N6rYo4s1LoW2SzYTZySjSzGcPOJo0icdgfpNdnJg3bIrAL7B9atIqUrLtBUrRFTwcd5hLkGySeoVsI8K7RRIzAYKekl7VNVsUzs0beraYhJDUbyyUpdtZYkeurGWr89QYSVrBWxA82tBaguBwozIeK%2F0FghGlcZpgqQz6civjmGoY8VoZIZHv9JXRdAecsa%2Fqko3IeHnLXVGueaGhODtTnfKoosGkNAiaTCp%2Fot7rNOrAtiOZHL8vTTOMqHUUdC7SEZHb%2Bc7ZjnPMXQTtcIcla7pQpvwTyfJuwV%2BwfiFYdw

Steps to reproduce

click the button

System Info

web

Additional Information

It's really a mistake by the dev but if we can fix it we should.

Likely we'll only be able to handle the sync case, by handling retries inside the qrl apply

@JerryWu1234
Copy link
Contributor

@wmertens
Are you doing right now ?

@wmertens
Copy link
Member Author

@JerryWu1234 no, feel free to take a look at retryOnPromise and make it so calling the qrl normally can retry

@JerryWu1234
Copy link
Contributor

@JerryWu1234 no, feel free to take a look at retryOnPromise and make it so calling the qrl normally can retry

Sorry for replying late.
now, have you already fixed it ?

@wmertens
Copy link
Member Author

Not fixed yet :)

@JerryWu1234 JerryWu1234 self-assigned this Mar 24, 2025
@JerryWu1234
Copy link
Contributor

thanks, I'll deep into it this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants