Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add support for sending notifications to a topic (Refactor?) #76

Open
yatharthranjan opened this issue Jan 13, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request neverstale

Comments

@yatharthranjan
Copy link
Member

yatharthranjan commented Jan 13, 2020

Is your feature request related to a problem? Please describe.
Currently, a notification can only be sent to a particular user. Which is sufficient for current use-case of the aRMT app but not future proof.

Describe the solution you'd like
There could be a new endpoint with path /topic/{topic_id} though which it should be possible to send notifications to a particular set of users registered on that topic. A schedule function should be investigated if feasible and necessary at this endpoint. This will need to add a new property to user of type list that will store all it's registrations to various topics. This can also be achieved easily if using FCM as suggested in the alternatives below.

Describe alternatives you've considered
Currently, this is supported by adding a notification with a fcmTopic property. which could be useful if using FCM but will only work with FCM. Also the management of topics is out of the appserver so there is no way of knowing which topics exist, if the message was sent to the correct topic and if the user is on a particular topic or not.

Priority
8

Difficulty
6

Additional context
Will need a new function in the user repo to findByFcmToken

@yatharthranjan yatharthranjan added the enhancement New feature or request label Jan 13, 2020
@yatharthranjan yatharthranjan self-assigned this Jan 13, 2020
@stale
Copy link

stale bot commented Jul 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 11, 2020
@stale stale bot removed the wontfix This will not be worked on label Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request neverstale
Projects
None yet
Development

No branches or pull requests

1 participant