Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a message if loading participants has failed #74

Open
nivemaham opened this issue Sep 18, 2019 · 1 comment
Open

Show a message if loading participants has failed #74

nivemaham opened this issue Sep 18, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request upload-frontend
Milestone

Comments

@nivemaham
Copy link
Collaborator

Currently, the user is not informed if loading participants has failed. This should be added to the UI.
const patientList = await patientAPI.filteredPatients(projectId).catch(() => ([]));
The catch should print the error and show a message to the user, similar to what we do when file upload failes

@nivemaham nivemaham added enhancement New feature or request upload-frontend labels Sep 18, 2019
@nivemaham nivemaham added this to the v0.2.0 milestone Sep 18, 2019
@khoathanglong
Copy link
Collaborator

Currently all GET requests are expected not to fail. I have not implemented any catch on these case since I need more specific requirement for handling get fail not just participants but sourceTypes, files, records...
I suggest to move this in milestone 3 as an improvement. Since the table also said 'no data found' if get participants fails.

@nivemaham nivemaham modified the milestones: v0.2.0, v0.3.0 Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request upload-frontend
Projects
None yet
Development

No branches or pull requests

2 participants