Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sha2 dep once bitcoin_hashes provide hardware accelerated sha256 #28

Open
RCasatta opened this issue Jul 27, 2023 · 2 comments
Open

Remove sha2 dep once bitcoin_hashes provide hardware accelerated sha256 #28

RCasatta opened this issue Jul 27, 2023 · 2 comments

Comments

@RCasatta
Copy link
Owner

rust-bitcoin/rust-bitcoin#1962
rust-bitcoin/rust-bitcoin#1424
@RCasatta
Copy link
Owner Author

RCasatta commented Nov 1, 2023

@romanz: released rust bitcoin now has hardware accelerated sha on x86 platforms, I would like to drop sha2 feature/dep in its favor but I think we will be missing acceleration on arm, should we do it or wait for bitcoin_hashes to add hardware acceleration on arm?

@romanz
Copy link
Contributor

romanz commented Nov 2, 2023

Good point, thanks!
It seems indeed that sha2 has specific optimizations for ARM-based devices:
RustCrypto/hashes#490
RustCrypto/hashes#507
https://github.com/RustCrypto/hashes/tree/master/sha2/src/sha256
If possible, let's wait :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romanz @RCasatta