Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production of ADADAS #16

Open
5 tasks
bms63 opened this issue Jan 28, 2025 · 2 comments
Open
5 tasks

Production of ADADAS #16

bms63 opened this issue Jan 28, 2025 · 2 comments
Assignees

Comments

@bms63
Copy link
Contributor

bms63 commented Jan 28, 2025

Background

Goal: Produce dataset using existing Pilot 3 code in the datasetjson format

Definition of Done

  • Pilot 3 Code brought up to date with latest package versions
  • Spec file is up to date
  • datasetjson file is produced
  • Comparison down back to Pilot 3 dataset
  • Document Findings in [TBD]
@bms63 bms63 moved this to Todo in Pilot 5: datasetjson Jan 28, 2025
@cpiraux cpiraux self-assigned this Feb 3, 2025
@bms63 bms63 moved this from Todo to In Progress in Pilot 5: datasetjson Mar 7, 2025
@cpiraux
Copy link
Collaborator

cpiraux commented Mar 9, 2025

@RConsortium/pilot5 , I have a question regarding the dataset JSON datatype. It is mentioned in the vignette that "this information must be provided directly by the user." As a user, I see two ways to assign the datatype for dataset JSON:

  • The first approach is to map the dataframe datatype to the closest corresponding dataset JSON datatype. For example, if TRTPN = 1 and we don't specifically indicate that it is an integer, it will be saved as a double. In dataset JSON, the datatype is then assigned as "double."
  • The second approach involves using metadata that follows the Define.xml specification. In this example, TRPN has an integer datatype in the specification, and TRTPN is a double in R; thus, the datatype in dataset JSON would be assigned as "integer." This means that the variables, which have a double datatype in the sending system, will have an integer datatype in the receiving system.

@robertdevine
Copy link
Collaborator

@RConsortium/pilot5 - the {xportr} 'Go meta' implementation provides Get/Set options for type coercion irrespective of {package} defaults. Deep dive here.

@robertdevine robertdevine mentioned this issue Mar 10, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

3 participants