-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catalogs listing query bug #271
Comments
There was an ongoing discussion here #235 However.. I have some changes to define custom endpoints I'll push soon. What's the full set of your Classes / relations between them? Something like this? {
"name": "Catalog Record",
"hierarchy": [
{
"rdfClass": "http://www.w3.org/ns/dcat#Catalog",
"className": "Catalog",
"hierarchyLevel": 1
},
{
"rdfClass": "http://www.w3.org/ns/dcat#Dataset",
"className": "Dataset",
"hierarchyLevel": 2
},
{
"rdfClass": "http://www.w3.org/ns/dcat#Resource",
"className": "Resource",
"hierarchyLevel": 3
}
],
"relations": [
{
"levelFrom": 1,
"levelTo": 2,
"direction": "outbound",
"rdfPredicate": "http://purl.org/dc/terms/hasPart"
},
{
"levelFrom": 2,
"levelTo": 3,
"direction": "outbound",
"rdfPredicate": "http://purl.org/dc/terms/hasPart"
}
]
} any others? vocab routes? |
yeah I have some vocab with just two levels
and the catalog record heirarchy is just
|
Could you confirm if it's still an issue when defining your own custom endpoints now #274 has been merged |
well it is still an issue in the sense that it does not show catalogs that only have dcat:Resources in them by default. would it be a problem to add dcat:Resource to the default endpoint nodeshape properties? |
Ah, I had in fact added it back to the default endpoints too ex:shape-R0-HL3-2 a sh:NodeShape ;
sh:property [ sh:class dcat:Dataset ;
sh:path [ sh:inversePath dcterms:hasPart ] ],
[ sh:class dcat:Catalog ;
sh:path ( [ sh:inversePath dcterms:hasPart ] [ sh:inversePath dcterms:hasPart ] ) ] ;
sh:targetClass dcat:Resource ;
ont:hierarchyLevel 3 . |
doesn't that only allow
but I am suggesting to allow
|
Apologies yes the former there @nicholascar what is the preferred Prez default for "CatPrez" - is it to have the three tier Catalog/Dataset/Resource or the Catalog/Resource . Whichever we choose, we can support the other via configurable endpoints, just need to decide what we want the default to be. |
Catalog/Resource It's simpler and also it's the OGC Records API equivalent which is the "top-level" style catalogue |
This is now a default route in prez |
Issue
browsing /catalogs shows no results.
expected behaviour
a list of catalogs is returned.
suspected cause
the main query generated by
prez/prez/services/listings.py
Line 100 in 4ce71b7
the code for the listings_function function and PrezQueryConstructor class don't seem to have been changed so probably it is a profile thing.
question
is this the intended behaviour now? or is this a bug
note
see below screengrab for old vs new query as captured in the debugger
The text was updated successfully, but these errors were encountered: