Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor parallel execution in semi.sup.R and two.step.hybrid.R #38

Open
maximskorik opened this issue Jun 8, 2022 · 1 comment
Open
Labels
bug Something isn't working

Comments

@maximskorik
Copy link
Member

two.step.hybrid.R and semi.sup.R rely on parallel execution with R's parallel package. Instead of exporting individual functions to clusters the whole package is exported (once in two.step.hybrid, 6 times in semi.sup).

clusterEvalQ(cluster, library(recetox.aplcms))

Such an approach requires recetox.aplcms package to be installed prior to testing, which is wrong. The solution would be to register each cluster's individual functions instead of the whole package, e.g., clusterEvalQ(cluster, "adjust.time").
However, that approach distorts cache handling: some cache files won't get written on disk.


The task is to refactor the parallel execution so that two-step-hybrid test passes without having recetox.aplcms package installed.

@maximskorik maximskorik added the bug Something isn't working label Jun 8, 2022
@maximskorik
Copy link
Member Author

maximskorik commented Jun 10, 2022

The issue can also be solved by using hybrid() instead of semi.sup() in two.step.hybrid, after #35 is resolved. That may be the best solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant