Skip to content

Floating point minimum and maximum standard #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajz34 opened this issue Mar 6, 2025 · 0 comments
Open

Floating point minimum and maximum standard #6

ajz34 opened this issue Mar 6, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@ajz34
Copy link
Member

ajz34 commented Mar 6, 2025

Careful implementation of floating point (f32, f64) minimum and maximum should be considered and implemented in a later time.

Current implementation of functions min_all and max_all seems not adhering Array API Standard on NaN values. Also, numpy distinguishes NaN value handling for argmin and nanargmin.

To achieve this, we may either use unstable feature rust-lang/rust#91079 (also c.f. rust-num/num-traits#323), or either implement in our own.

In this current status, we may either using PartialOrd or MinMaxAPI for correct handling of non-nan cases. Using max/min utilities in RSTSR with NaN should be considered as unspecified behaviors.

@ajz34 ajz34 added the enhancement New feature or request label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant