Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small typos #10

Open
agmui opened this issue Dec 11, 2023 · 0 comments
Open

Small typos #10

agmui opened this issue Dec 11, 2023 · 0 comments

Comments

@agmui
Copy link

agmui commented Dec 11, 2023

Random broken link(addition info for cloning repo lab1) I am assuming it is suppose to go to here?

image

labs repository by following the [appropriate


SIGCHLD typo (simpeshell lab2)

image

signal(SIGCHL, handle_sigchld);


No chmod +x for python script

image

$ ./grade-lab-0.py warmup


Saying wsl was misleading linux users when setting up

image


More test cases are needed for clab xv6

  • string_with_q only has test cases where the second char in the string is Q. There needs to be test cases where the first char is a Q
  • check for memory leaks when testing al

Tell students to do err checking for fork and execlp in simple shell

When grading many students forgot to check the result of fork().

# Step 1: Executing Foreground Commands


Explicitly state you need to be able to run ls, cat, cd ... in simpleshell

I had a student who were confused because the lab did not explicitly state that the simple shelled needed to be able to run other commands besides ./donothing

# Step 1: Executing Foreground Commands

nouredd2 added a commit that referenced this issue Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant