From de5cef09471fce09fa920794c95e3e572b0366fe Mon Sep 17 00:00:00 2001 From: Bas Stottelaar Date: Thu, 9 Jan 2025 22:47:14 +0100 Subject: [PATCH 1/2] CODING_CONVENTIONS.md: bump minimum Python version Raising the minimum version is only a formality. Several features, such as f-strings are already used in the code base. In addition, the CI builds use a Docker images based on Ubuntu 22.04. Ubuntu 22.04 ships with Python 3.10. --- CODING_CONVENTIONS.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CODING_CONVENTIONS.md b/CODING_CONVENTIONS.md index c917d8664fe1..f274476e27e7 100644 --- a/CODING_CONVENTIONS.md +++ b/CODING_CONVENTIONS.md @@ -452,8 +452,8 @@ not a string literal`. ## Python coding convention -* Code shall be compliant with Python 3.5 minimum because this is the default - Python 3 version in Ubuntu 16.04 (used as the reference system for CI) +* Code shall be compliant with Python 3.10 minimum because this is the default + Python 3 version in Ubuntu 22.04 (used as the reference system for CI) * Code shall report no error when running the [Flake8](http://flake8.pycqa.org/en/latest/) tool, e.g: * for style checks described in From 4e7e28bb07b00cf62cba72372202023418ac2ac0 Mon Sep 17 00:00:00 2001 From: Bas Stottelaar Date: Fri, 10 Jan 2025 07:33:18 +0100 Subject: [PATCH 2/2] CODING_CONVENTIONS.md: improve spelling in Python section Minor formatting and spelling corrections in the Python coding convention section. --- CODING_CONVENTIONS.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/CODING_CONVENTIONS.md b/CODING_CONVENTIONS.md index f274476e27e7..d6d58b4a5d7a 100644 --- a/CODING_CONVENTIONS.md +++ b/CODING_CONVENTIONS.md @@ -452,17 +452,18 @@ not a string literal`. ## Python coding convention -* Code shall be compliant with Python 3.10 minimum because this is the default - Python 3 version in Ubuntu 22.04 (used as the reference system for CI) +* Code shall be compliant with Python 3.10 at minimum, because this is the + default Python 3 version in Ubuntu 22.04 (used as the reference system for + CI). * Code shall report no error when running the [Flake8](http://flake8.pycqa.org/en/latest/) tool, e.g: * for style checks described in - [PEP8](https://www.python.org/dev/peps/pep-0008/), + [PEP 8](https://www.python.org/dev/peps/pep-0008/), * for lint checks provided by [Pyflakes](https://pypi.python.org/pypi/pyflakes), * for complexity checks provided by the [McCabe project](https://pypi.python.org/pypi/mccabe) -* A line length of maximum of 120 is allowed instead of the pep8 79: this +* A line length of maximum of 120 is allowed instead of 79 as per PEP 8. This increases tests readability as they can expects long line of output. * Only runnable scripts shall start with `#!/usr/bin/env python3` * Runnable scripts shall use the following scheme: