Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GBA problems #100

Open
chrysn opened this issue Aug 20, 2024 · 3 comments
Open

GBA problems #100

chrysn opened this issue Aug 20, 2024 · 3 comments

Comments

@chrysn
Copy link
Member

chrysn commented Aug 20, 2024

PR #89 was auto-closed because it was merged as part of #90 but then some of it was reverted: In particular, some portable-atomic backend needs to be enabled (and we don't have that yet)

Just enabling portable-atomic-unsafe-assume-single-core does not work because it breaks builds for native; some notes are in #89 on how to continue.

CC'ing @Teufelchen1 who opened the original PR.

@chrysn
Copy link
Member Author

chrysn commented Aug 20, 2024

Relatedly, tests/ztimer-async directly enables critical-section on portable-atomic. Could that be part of a solution here?

@Teufelchen1
Copy link
Contributor

Could you link that tests/ztimer-async section? I think I misunderstood since I can't find it.

@chrysn
Copy link
Member Author

chrysn commented Sep 25, 2024

portable-atomic = { version = "1.6", default-features = false, features = [ "critical-section" ] }
and the provide_critical_section_1_0 a few lines above.

(On the long run, RIOT's modules should enable all these with the per-board correct settings, but what is in there should AIU work everywhere now, in which case those settings should be enabled more widely)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants