Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll over to stable embedded-hal #65

Closed
chrysn opened this issue Oct 22, 2023 · 1 comment
Closed

Roll over to stable embedded-hal #65

chrysn opened this issue Oct 22, 2023 · 1 comment
Assignees
@chrysn
Labels
wait-for-breaking-0.9 Change that is held for the 0.9 release, for it is a breaking change

Comments

@chrysn
Copy link
Member

chrysn commented Oct 22, 2023

There is now an RC1 of embedded-hal, let's update.

Unless someone says here that they want to migrate slowly, I'd make this a flag day switch with the next breaking version.
@chrysn chrysn added the wait-for-breaking-0.9 Change that is held for the 0.9 release, for it is a breaking change label Oct 22, 2023
@chrysn chrysn self-assigned this Oct 22, 2023
@chrysn
Copy link
Member Author

chrysn commented Aug 19, 2024

In #73, embedded-hal 1.0 was added without removing 0.2 support.

Still, 0.2 support is in for some peripherals; removing that as part of 0.9. (embedded-hal 0.2 support is staying in for peripherals that don't have a HAL in 1.0 -- not sure what to do with those).

chrysn added a commit that referenced this issue Aug 19, 2024
@chrysn
Drop support for embedded-hal 0.2 except where 1.0 has no traits for …
b688639 
…it (ADC)

SPI is not dropped either because the 1.0 trait includes acquisition in
the trait (which makes it not trivial to port).

Closes: #65
@chrysn chrysn closed this as completed in 2191ddf Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrysn chrysn

Labels
wait-for-breaking-0.9 Change that is held for the 0.9 release, for it is a breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrysn