Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider dealing with emissions factors in ABCD data more cautiously #3

Open
cjyetman opened this issue Sep 7, 2022 · 0 comments
Open

consider dealing with emissions factors in ABCD data more cautiously #3

cjyetman opened this issue Sep 7, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@cjyetman
Copy link
Member

cjyetman commented Sep 7, 2022

here...
https://github.com/2DegreesInvesting/pacta.data.preparation/blob/04ed2a54fcb20589086937a2d58ed994871ec78f/run_pacta_data_preparation.R#L358-L364

and here...
https://github.com/2DegreesInvesting/pacta.data.preparation/blob/04ed2a54fcb20589086937a2d58ed994871ec78f/run_pacta_data_preparation.R#L413-L419

we set the emissions factors to 0 if the technology is in the user-specified list of zero_emission_factor_techs and the production values are greater than 0. This seems hella questionable and we should consider doing whatever this is trying to achieve in a more sensible way.
@jdhoffa jdhoffa added the enhancement New feature or request label Nov 17, 2022
@jdhoffa jdhoffa transferred this issue from another repository Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjyetman @jdhoffa