Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_ishares_index_data should output and save the raw html pages #37

Open
jdhoffa opened this issue Feb 2, 2024 · 0 comments
Open

get_ishares_index_data should output and save the raw html pages #37

jdhoffa opened this issue Feb 2, 2024 · 0 comments
Labels
breaking change ☠️ API change likely to affect existing code feature a feature request or enhancement maintenance-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Feb 2, 2024

Currently this function saves the html files (both the data URL and the page URL) as temporary files within the body of get_ishares_index_data. It would be good to save the source data explicitly for every index pulled.

Relates to #162
@jdhoffa jdhoffa mentioned this issue Feb 2, 2024
Closed
@jdhoffa jdhoffa added breaking change ☠️ API change likely to affect existing code feature a feature request or enhancement maintenance-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day labels Feb 6, 2024
@jdhoffa jdhoffa self-assigned this Feb 6, 2024
@jdhoffa jdhoffa removed their assignment Apr 10, 2024
@cjyetman cjyetman added ADO and removed ADO labels Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change ☠️ API change likely to affect existing code feature a feature request or enhancement maintenance-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjyetman @jdhoffa