Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep: bump lifecycle from "experimental" to "stable" #73

Open
jdhoffa opened this issue May 4, 2024 · 4 comments
Open

upkeep: bump lifecycle from "experimental" to "stable" #73

jdhoffa opened this issue May 4, 2024 · 4 comments

Comments

@jdhoffa
Copy link
Member

jdhoffa commented May 4, 2024

This package has about 95% test coverage, and is currently used in production.

@cjyetman do you think this package is ready to bump to "stable", and if not, are there specific tasks or issues that you think are blocking it from becoming so?

AB#10914

@cjyetman
Copy link
Member

cjyetman commented May 4, 2024

I have been questioning whether there should be both assert_valid_*() and is_valid_*() style functions for each data type it knows, one that errors or returns TRUE invisibly and one that returns TRUE or FALSE. That would be a rather large "interface" change. There are also a few significant things missing.

@cjyetman
Copy link
Member

cjyetman commented May 4, 2024

And some important things to fix like #69

@cjyetman
Copy link
Member

cjyetman commented May 4, 2024

also could consider making expect_*() style custom expectation functions for testing

@jdhoffa
Copy link
Member Author

jdhoffa commented May 4, 2024

Depends on #74
Depends on #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants