Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert interactive charts to D3v6 #10

Open
cjyetman opened this issue Jan 27, 2021 · 0 comments
Open

convert interactive charts to D3v6 #10

cjyetman opened this issue Jan 27, 2021 · 0 comments
Assignees

Comments

@cjyetman
Copy link
Member

Currently, the interactive charts are built on D3v4 plus some additional D3 libraries. r2d3 handles providing the default D3 libraries, but the additional D3 libraries need to be included in this repo/pkg, which is questionable whether we should actually be doing that and/or whether we need to include their licenses, credit their author/s, etc.

The reason for requiring the additional libraries is often because a certain D3 function was added to the micro library after D3v4 was built, and so it can't be accessed using the default library on its own, e.g. d3.rollup. In other cases, the micro library did not exist or was not included in D3v4, but was included in later versions of D3, e.g. d3-scale-chromatic.

If we depend on D3v6 instead, we will have access to all of the latest and greatest versions of the micro libraries and their functions. However, this may cause some problems with functions that have been deprecated, forcing us to update code that uses them to the current/modern way of doing things, e.g. d3.nest and d3.map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant