Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark metrics: Explain what these values are in more detail #105

Open
maurolepore opened this issue Jun 17, 2020 · 4 comments
Open

Benchmark metrics: Explain what these values are in more detail #105

maurolepore opened this issue Jun 17, 2020 · 4 comments
Labels
ADO Maintenance Day! documentation medium Likely finished in under a week

Comments

@maurolepore
Copy link
Contributor

maurolepore commented Jun 17, 2020

(Extracted from https://github.com/2DegreesInvesting/r2dii.analysis/pull/104#issue-435751759)

[Regarding] the benchmark output of target_market_share() (...) I think that these metric names are evocative and descriptive, however I think it would make sense to explain what these values are in a little more detail, where do you think the best place to host this is? I think we had briefly discussed the idea of a data_dictionary for the output, maybe this is the time to start thinking about that? -- @jdhoffa

AB#9905

@maurolepore
Copy link
Contributor Author

maurolepore commented Jun 17, 2020

If what we need to document is the output of ...

  • ... a single function, I would document it in the @retrurn section of that function.
  • ... multiple functions, I would consider documenting the multiple functions together (e.g. via @rdname); or document them separately but DRY the shared elements of @return via @template, or as we did with r2dii.match/vignettes/_validate-matches.md (that is #' @includeRmd vignettes/_validate-matches.md).

Instead of what I wrote above, it would be nice to document the output of all functions in a data_dictionary -- as we do in r2dii.data -- but this seems beyond the first release.

@maurolepore
Copy link
Contributor Author

@jdhoffa is this something we plan before or after the initial release?

@jdhoffa
Copy link
Member

jdhoffa commented Jun 20, 2020

I would say after actually, or at least after the internal review from colleagues to ensure our metric names are adequate and make sense

@jdhoffa
Copy link
Member

jdhoffa commented Jun 8, 2021

Relates to #269

@jdhoffa jdhoffa added medium Likely finished in under a week ADO Maintenance Day! and removed ADO Maintenance Day! labels Feb 6, 2024
@jdhoffa jdhoffa removed their assignment Feb 6, 2024
@jdhoffa jdhoffa added the ADO Maintenance Day! label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADO Maintenance Day! documentation medium Likely finished in under a week
Projects
None yet
Development

No branches or pull requests

2 participants