Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep: only use join_ald_scenario when necessary #149

Open
jdhoffa opened this issue Jul 29, 2020 · 1 comment
Open

upkeep: only use join_ald_scenario when necessary #149

jdhoffa opened this issue Jul 29, 2020 · 1 comment
Labels
feature a feature request or enhancement medium Likely finished in under a week upkeep maintenance, infrastructure, and similar

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Jul 29, 2020

join_ald_scenario is necessary to call prior to target_*. However, it pollutes summarize_* with unnecessary scenario columns, requiring either:

  1. the user to manually group the remaining columns
  2. the developer (me) to select the crucial columns and call distinct() prior to summarizing

1 puts a lot of onus on the user to know what they are doing (which i am skeptical of). 2 is a bit of a strict enforcement on our part... I propose we remove join_ald_scenario from the summarize_* helpfiles and regression tests, and assume the input has only lbk and ald columns, and suggest that the user use the ... argument to add further groups, in the case of inputs with multiple scenarios etc.

@jdhoffa jdhoffa added enhancement medium Likely finished in under a week labels Jun 14, 2021
@jdhoffa jdhoffa added feature a feature request or enhancement and removed enhancement labels Apr 14, 2023
@jdhoffa
Copy link
Member Author

jdhoffa commented Feb 6, 2024

Relates to #468

@jdhoffa jdhoffa added the upkeep maintenance, infrastructure, and similar label Mar 18, 2024
@jdhoffa jdhoffa changed the title Only use join_ald_scenario when necessary upkeep: only use join_ald_scenario when necessary Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement medium Likely finished in under a week upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

No branches or pull requests

1 participant