Remove green_or_brown in favour of increasing_or_decreasing

[jdhoffa]

Closes #434

[jdhoffa]

It is expected that some of these checks will fail until the latest version of https://github.com/RMI-PACTA/r2dii.data is on CRAN, since we are now depending on that latest dataset. As such, I will convert this to draft until that is the case.

Also, note to self, this package will now depend on a latest version of r2dii.data

[cjyetman]

Note in README please 😊

[jdhoffa]

Wait a sec, I'm a dingus.

The argument green_or_brown was only added in the development version of this package in the first place and never released, so don't need to deprecate it. Can just change it entirely to increasing_or_decreasing.

I'm a little rusty on working on CRAN-released packages :-D

[jdhoffa]

Ok @cjyetman this is now ready for review.

It was much easier than I anticipated, because green_or_brown was never actually an exported argument of any function in any of our CRAN releases, so I don't actually need to deprecate (I can just remove/ rename it as I wish)

[cjyetman]

weird that so many checks failed?

[jdhoffa]

weird that so many checks failed?

This is because of all of the warnings due to the many-to-many relationship, which I handled in a separate PR.

[jdhoffa]

weird that so many checks failed?

This is because of all of the warnings due to the many-to-many relationship, which I handled in a separate PR.

I have now merged that PR in. All checks should pass!

[cjyetman]

looks like all "R-CMD-check r2dii-devel" tests pass, but all "R-CMD-check" tests fail. not sure what the difference is between the two

[jdhoffa]

looks like all "R-CMD-check r2dii-devel" tests pass, but all "R-CMD-check" tests fail. not sure what the difference is between the two

devel uses the development version of dependency packages (e.g. r2dii.data and r2dii.match) to run checks, whereas the normal one uses the CRAN release.

This makes sense, since the functions now require the new dataset increasing_or_decreasing, which only exists in the development version of r2dii.data (it is not yet on CRAN). Once we release r2dii.data to CRAN, all checks should pass.