Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing expect_snapshot() test due to changes in r2dii.data #368

Closed
jdhoffa opened this issue Jun 18, 2021 · 1 comment
Closed

Failing expect_snapshot() test due to changes in r2dii.data #368

jdhoffa opened this issue Jun 18, 2021 · 1 comment
Assignees
@jdhoffa
Labels
bug an unexpected problem or unintended behavior small Likely finished in under a day

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Jun 18, 2021

Once r2dii.data v0.2.0 hits CRAN, I would expect one regression test to fail in r2dii.match. See https://github.com/2DegreesInvesting/r2dii.data/pull/237#issuecomment-864020338

This is an expected change, and the snapshot should just be updated. Also we might consider breaking the dependency on the tests in r2dii.match from changes made in r2dii.data.

Somewhat relates to https://github.com/2DegreesInvesting/r2dii.analysis/pull/230
@jdhoffa jdhoffa added bug an unexpected problem or unintended behavior small Likely finished in under a day labels Jun 18, 2021
@jdhoffa jdhoffa self-assigned this Jan 26, 2024
@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 26, 2024

Closed by #435

@jdhoffa jdhoffa closed this as completed Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdhoffa jdhoffa

Labels
bug an unexpected problem or unintended behavior small Likely finished in under a day
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdhoffa