Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assess if adding an R-Universe mirror allows a Dockerfile + DESCRIPTION install to function without Remotes #3

Open
jdhoffa opened this issue Feb 2, 2024 · 7 comments
Labels
question Further information is requested

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Feb 2, 2024

          NB (more of a question really, and not something we should solve in this PR): but I wonder if it would be possible/ interesting/ useful to just add or specify our R-universe instance as a package repository? so install from CRAN or RMI R-Universe. that way we don't need to jump through weird Remotes loops, the Dockerfile just knows that anything in our R-universe is valid to install. (obviously we would still need to sort out how to specify what version to install, but I think that is doable)

Originally posted by @jdhoffa in RMI-PACTA/workflow.transition.monitor#231 (comment)

Note: this issue isn't suggesting we actually do this, just assessing if it's feasible/ works well.

@jdhoffa jdhoffa added the question Further information is requested label Feb 2, 2024
@cjyetman
Copy link
Member

cjyetman commented Feb 2, 2024

My initial guess was from the context of adding non-CRAN pkgs in DESCRIPTION Depends: without Remotes: in an R package, which I assume is not feasible because we can't control what CRAN repositories a user will have installed when they try to use it. But also this use case, I'm not 100% sure if it will work.

@jdhoffa
Copy link
Member Author

jdhoffa commented Feb 2, 2024

Ah yeah totally fair point. It would sort of be abusing the purpose of a DESCRIPTION file in that case... I hadn't thought of it that way

@AlexAxthelm
Copy link
Collaborator

Looking at the R-universe docs+forums, I'm only seeing specifying options(repos=<foo>) as the way to point the install process at R-universe, but Remotes: seems to work pretty generally now that pak seems to have taken over the R-Lib ecosystem's install process.

@jdhoffa
Copy link
Member Author

jdhoffa commented Feb 2, 2024

Ok!

In that case happy to close this, if we all agree that DESCRIPTION + pak + Remotes is suitable as an installation process for our R packages (for now anyway)

@cjyetman
Copy link
Member

cjyetman commented Feb 2, 2024

https://remotes.r-lib.org/articles/dependencies.html

and an open feature request for allowing Remotes: to specify an r-universe
r-lib/remotes#618

@jdhoffa
Copy link
Member Author

jdhoffa commented Feb 2, 2024

you posted the same link! But if they are working on it, maybe good to leave this issue open

@cjyetman
Copy link
Member

cjyetman commented Feb 2, 2024

updated link. does not sound imminent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants