Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for read-only inputs #55

Closed
AlexAxthelm opened this issue Feb 26, 2024 · 2 comments · Fixed by #77 or #80
Closed

Allow for read-only inputs #55

AlexAxthelm opened this issue Feb 26, 2024 · 2 comments · Fixed by #77 or #80

Comments

@AlexAxthelm
Copy link
Contributor

Currently, the workflow writes tot he same directory that it reads data from. Since the input data (which is the outputs from workflow.data.preparation) should be read only, we need to update to write the output files from this process to a separate directory.

workflow.prepare.pacta.indices/prepare_pacta_indices.R

Lines 27 to 30 in 7a7a0bb

working_dir <- file.path(transition_monitor_dir, "working_dir")
input_dir <- file.path("/pacta-data/", pacta_financial_timestamp)
output_dir <- input_dir

cc @jdhoffa
@cjyetman cjyetman mentioned this issue Feb 27, 2024
Closed
@cjyetman cjyetman linked a pull request Feb 27, 2024 that will close this issue
feat: writes output to INDICES_PREPARATION_OUTPUTS_PATH #77
Merged
@cjyetman
Copy link
Member

closed by #77

@AlexAxthelm AlexAxthelm reopened this Feb 27, 2024
@AlexAxthelm
Copy link
Contributor Author

#77 didn't actually mark the inputs as read only.

AlexAxthelm added a commit that referenced this issue Feb 27, 2024
@AlexAxthelm
ci(docker): #55 Mark inputs directory as read-only
2d8ffcb 
update docker-compose such that the inputs (`pacta-data`) directory is
read-only, while write is permitted for outputs

Closes: #55
@AlexAxthelm AlexAxthelm mentioned this issue Feb 27, 2024
Merged
AlexAxthelm added a commit that referenced this issue Feb 27, 2024
@AlexAxthelm
ci(docker): #55 Mark inputs directory as read-only (#80)
7159e7e 
update docker-compose such that the inputs (`pacta-data`) directory is
read-only, while write is permitted for outputs

Closes: #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cjyetman @AlexAxthelm