You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have some feedback, I will paste it below but if you have interest to take it further, I can split it up into one issue per item (and, cautiously, maybe can submit PRs - never developed GH actions before, though):
support for dir separators in the glob - GLOBAL_PATTERN: "blabla/*.yml" fails because find does not like it (‘-name’ matches against basenames only, but the given pattern contains a directory separator (‘/’), thus the expression will evaluate to false all the time. Did you mean ‘-wholename’?)
avoid committing state into the repo (rml_action_meta) - would be good to put it behind a flag. But, perhaps, you wanted to avoid spurious changes by RDF resource reordering - https://www.w3.org/TR/rdf-canon/ could be helpful.
Update README with latest checkout@v2 action declaration
ignore empty string - example (I think this is due to bad JSON where the key was present with the "" value - would be good to have some processor to ignore that and treat such props as missing)
try git pull --rebase before push - otherwise the action run and all re-runs fail if a new push was made to the repo
do not run npm i, it can change installed deps between executions; add a lockfile and run npm ci - though I am not an expert in JS
configurable suffix instead of _output including no suffix
the action is a wee bit behind the RMLio/rmlmapper-java releases
Again, this GH Action and YARRRML are seriously good! Thank you so much.
The text was updated successfully, but these errors were encountered:
@elytvyno @pheyvaer thanks for making this action!
I just set it up on my repo to convert some random JSON files into minimal W3C SPARQL 1.2 Service Description dumps. I used R2RML ca. 10 years ago and using your tool and YARRRML is a breeze!
I have some feedback, I will paste it below but if you have interest to take it further, I can split it up into one issue per item (and, cautiously, maybe can submit PRs - never developed GH actions before, though):
find
does not like it (‘-name’ matches against basenames only, but the given pattern contains a directory separator (‘/’), thus the expression will evaluate to false all the time. Did you mean ‘-wholename’?)rml_action_meta
) - would be good to put it behind a flag. But, perhaps, you wanted to avoid spurious changes by RDF resource reordering - https://www.w3.org/TR/rdf-canon/ could be helpful.""
value - would be good to have some processor to ignore that and treat such props as missing)git pull --rebase
before push - otherwise the action run and all re-runs fail if a new push was made to the reponpm i
, it can change installed deps between executions; add a lockfile and runnpm ci
- though I am not an expert in JS_output
including no suffixAgain, this GH Action and YARRRML are seriously good! Thank you so much.
The text was updated successfully, but these errors were encountered: