Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reason for removal of support for Dynamixel models in release 2.2.3 #384

Open
nilp-dromeda opened this issue Jul 24, 2024 · 4 comments
Open

Comments

@nilp-dromeda
Copy link

nilp-dromeda commented Jul 24, 2024

I am currently using the newest release 2.2.3 to interact with Dynamixels that we are using. One of the key requirements was to be able to enable Current based position control on the dynamixels. We use a few different versions of dynamixels and most of them were enabled to current based position control, however the dynamixel-workbench-toolbox did not allow for the two models shown below:

  • XL330-M288-T
  • XC330-T288-T

Upon looking at the source code for release 2.2.3 I realised that a lot of the supported Dynamixel models were removed from dynamixel_workbench.cpp relative to the master branch. I have included a diff file which details the the if condition checks that had a variety of models removed from them (patch file not supported for upload on linux):

Git diff between 2.2.3 and master for dynamixel_workbench.cpp

What is the reason for these motor models not being added from master into release 2.2.3?

@pazeshun
Copy link

pazeshun commented Dec 5, 2024

Now master and develop branches are deleted, so we have no way to move XL330/XC330 actuators on ROS Noetic with this repository.
The minimum necessary commit does not belong to any branch on this repository.
@robotpilot Do you have any plan to recover from this situation?

@robotpilot
Copy link
Member

@pazeshun
I sincerely apologize for any inconvenience caused.
For a long period, maintenance of open-source codes like the Dynamixel SDK and Workbench has not been carried out. As we organized the previous codes under a new plan and created new branches for future development, this issue arose. This was my oversight. I have temporarily restored the master and develop branches you mentioned. In the future, these branches will be better managed under new branches. Once again, I sincerely apologize for any inconvenience.

@pazeshun
Copy link

pazeshun commented Dec 5, 2024

@robotpilot
Thank you very much for your support.
I found master branch lost one commit:
67a1631

Also, we have some PRs which were automatically closed by the branch deletion:
#385
#386
#379

Will In the future, these branches will be better managed under new branches take long time?
If so, we will re-create those PRs against current master for now.

@robotpilot
Copy link
Member

robotpilot commented Dec 5, 2024

@pazeshun Thank you very much for your support. I merged the the commit and reopen the you mentioned PRs. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants