You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, when we kill dynamixel_workbench_controllers with Ctrl-C, the motors are left torque on.
However, I think this is due to a bug of dynamixel_workbench_controllers.
Expected behavior is making the motors torque off:
and current code does not call delete against that pointer.
This causes a memory leak.
Although this seems a bug, many people probably depends on the current behavior and that memory leak is not fatal to the PC.
So I just leave this issue without fixing it.
Currently, when we kill
dynamixel_workbench_controllers
with Ctrl-C, the motors are left torque on.However, I think this is due to a bug of
dynamixel_workbench_controllers
.Expected behavior is making the motors torque off:
dynamixel-workbench/dynamixel_workbench_toolbox/src/dynamixel_workbench_toolbox/dynamixel_driver.cpp
Lines 29 to 37 in 67a1631
But this destructor is not called because
dxl_wb_
(pointer to instance ofDynamixelWorkbench
(child class ofDynamixelDriver
)) is a bare pointer:dynamixel-workbench/dynamixel_workbench_controllers/include/dynamixel_workbench_controllers/dynamixel_workbench_controllers.h
Line 75 in 67a1631
dynamixel-workbench/dynamixel_workbench_controllers/src/dynamixel_workbench_controllers.cpp
Line 45 in 67a1631
and current code does not call
delete
against that pointer.This causes a memory leak.
Although this seems a bug, many people probably depends on the current behavior and that memory leak is not fatal to the PC.
So I just leave this issue without fixing it.
Related to #386
The text was updated successfully, but these errors were encountered: