Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support beta for ConvolutionBackward functions. #372

Open
charles-r-earp opened this issue Aug 10, 2020 · 3 comments
Open

Support beta for ConvolutionBackward functions. #372

charles-r-earp opened this issue Aug 10, 2020 · 3 comments
Assignees
Labels
enhancement question request_for_comments See https://en.wikipedia.org/wiki/Request_for_Comments

Comments

@charles-r-earp
Copy link

It appears that the latest version of the miopen-hip package does not support beta != 0 for ConvolutionBackwardData, ConvolutionBackwardWeights, and ConvolutionBackwardBias, (and ConvolutionForward as well?). While it is possible to work around this, this generally requires a temporary to assign the output to, and then a saxpy post op. This is particularly useful when the weights are shared or the network recurs in the same graph. In the case of backward data, any time the same input is connected to multiple subsequent layers, it is ideal if the gradient can be accumulated directly rather than separately.
Note that cuDNN supports beta in the equivalent functions.
Is there any planned support for this and or how feasible is this change? Thanks.

@aserio aserio added enhancement question request_for_comments See https://en.wikipedia.org/wiki/Request_for_Comments labels Aug 14, 2020
@atamazov
Copy link
Contributor

@ppanchad-amd
Copy link

@atamazov I'm not able to access link you provided in your post. Is there a plan for supporting beta for ConvolutionBackward functions?

@atamazov
Copy link
Contributor

atamazov commented Apr 5, 2024

@ppanchad-amd

I'm not able to access link you provided in your post.

Please request for privileges that necessary to access the private MIOpen repo. Ask @junliume or @JehandadKhan for details.

Is there a plan for supporting beta for ConvolutionBackward functions?

All convolutions are missing support for ALPHA and BETA. IIRC there is no specific plan (with deadline etc) yet. But such an feature is needed (albeit this is not a showstopper), and we have it in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement question request_for_comments See https://en.wikipedia.org/wiki/Request_for_Comments
Projects
None yet
Development

No branches or pull requests

5 participants