You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The CXX_EXTENSIONS property is set to off in multiple CMake files in clr, but non-standard features are used so this property should be enabled.
Most compilers silently allow extensions unless -Wpedantic or specific warnings for extensions are enabled so there's no warning by default. Adding -Wpedantic or specific warnings like Wgnu-zero-variadic-macro-arguments to CXXFLAGS finds multiple places relying on extensions.
/build/source/rocclr/utils/debug.hpp:196:64: error: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Werror,-Wgnu-zero-variadic-macro-arguments]
196 | amd::log_printf( hipMemcpyHtoA
level, __FILENAME__, __LINE__, format, ##__VA_ARGS__); \
|
/build/source/rocclr/platform/memory.hpp:204:5: error: anonymous structs are a GNU extension [-Werror,-Wgnu-anonymous-struct]
204 | struct {
| ^
/build/source/rocclr/platform/memory.hpp:204:5: error: anonymous types declared in an anonymous union are an extension [-Werror,-Wnested-anon-types]
The text was updated successfully, but these errors were encountered:
The
CXX_EXTENSIONS
property is set to off in multiple CMake files in clr, but non-standard features are used so this property should be enabled.Most compilers silently allow extensions unless
-Wpedantic
or specific warnings for extensions are enabled so there's no warning by default. Adding-Wpedantic
or specific warnings likeWgnu-zero-variadic-macro-arguments
to CXXFLAGS finds multiple places relying on extensions.The text was updated successfully, but these errors were encountered: