Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMAKE_INSTALL_<dir> paths assumed to be relative #121

Closed
Madouura opened this issue Dec 24, 2022 · 4 comments
Closed

CMAKE_INSTALL_<dir> paths assumed to be relative #121

Madouura opened this issue Dec 24, 2022 · 4 comments

Comments

@Madouura
Copy link

Please see: https://github.com/jtojnar/cmake-snips#assuming-cmake_install_dir-is-relative-path
For context: ROCm/hipamd#55

Here is an example:
https://github.com/RadeonOpenCompute/rocm-cmake/blob/027404a8326da6e7e9338e0b81f9428660190724/share/rocm/cmake/ROCMInstallTargets.cmake#L87-L96
This assumes that CMAKE_INSTALL_<DIR> is relative, which is definitely not always the case.

@cgmb
Copy link
Collaborator

cgmb commented Dec 28, 2022

The PREFIX option is not used anymore, so the problem is further down. I should talk with @lawruble13 about this, since I don't fully understand the purpose of ROCMInstallTargets vs. the built-in CMake export and install. With the /opt/rocm file reorganization completed, I wonder if we might be able to simplify our build code for this functionality.

@cgmb
Copy link
Collaborator

cgmb commented Jan 9, 2023

I'm looking at my schedule for the next month and I'm not sure when I'm going to get a chance to really dig into this, so I'm marking this as help wanted. The problem is simple enough, but it's not immediately obvious to me how to fix this without breaking existing code.

@nartmada
Copy link

@Madouura, has this issue been fixed? Please close the ticket if the issue has been fixed. Thanks.

@ppanchad-amd
Copy link

@Madouura Closing ticket since there is no response. Please re-open if you still encounter this issue. Thanks!

@ppanchad-amd ppanchad-amd closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants