-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block loading/saving campaign from/to installation dir #4262
Block loading/saving campaign from/to installation dir #4262
Conversation
When I put myself in the shoes of a user that have fallen into this trap, I see two problems on the loading side (saving side seem fine to me):
We can help the user out a bit more by:
|
I do like forcing them to Save As immediately. However, if they Cancel out of that dialog (or just close it), the File > Save option should be disabled, forcing them to use File > Save As... and picking a new location. |
Does this extend to when people try to save other MT assets to the install directory like tokens, tables, campaign props, macro sets, etc? |
The updated change blocks Campaign, Tokens, Tables, Props, Macros, Maps from being saved into the install directory. It does not yet stop screenshots (they are handled differently. so I will get to them in a later change, they are also less likely to be a problem.) |
Identify the Bug or Feature request
Partially addresses #4209
Description of the Change
This change will stop users from saving campaign files into the installation directory.
If the user tries to do so a dialog will appear telling them that they are unable to do so and after clicking Ok they will be returned to the save dialog where they can choose another location.
As well as this if the user attempts to load a campaign file from the installation directory a dialog will appear informing them its not supported and asking them to copy the file elsewhere and try again. In this case they will not be returned to the load dialog.
Possible Drawbacks
I was not able to address the other requirements like default install to use version number as all attempts I tried just broke the msi builder.
Release Notes
This change is