Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Template TBB parameters ignored in Page rendering #38

Open
willprice76 opened this issue Jul 24, 2019 · 3 comments
Open

Component Template TBB parameters ignored in Page rendering #38

willprice76 opened this issue Jul 24, 2019 · 3 comments

Comments

@willprice76
Copy link
Contributor

We want to vary DXA TBB parameters such as the expandLinkDepth on a Component Template by Component Template basis, however if we set these TBB parameters on Component Template level, they are ignored when a Page is rendered - only TBB parameters set on Page Template level are picked up (but this obviously doesn't give the flexibility to alter the parameters per template). Is this a bug? I guess this might work as required if the DXA Custom Resolver were used and we published everything as Data Presentations, but it would be nice if it also worked without it.

@rpannekoek
Copy link
Contributor

This is not a bug. When building a DXA R2 Page Model, the parameters on "Generate R2 Page Model" TBB are used. When building a DXA R2 Entity Model for a DCP, the parameters on "Generate R2 Entity Model" TBB are used.
Indeed, it may be more flexible if embedded Entity Models can be configured separately, but that is currently not the case. Valid Enhancement Request, though.

@willprice76
Copy link
Contributor Author

As far as I can remember DD4T does take the expandLinkDepth from the CT (its called LinkLevels in DD4T) rather than the PT, so you could say that this is a bug introduced in DXA 2.0 with the new templates...

@willprice76
Copy link
Contributor Author

willprice76 commented Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants