Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebRequestContextImpl.getBaseUrl gives a full URL #80

Open
willprice76 opened this issue Sep 29, 2017 · 0 comments
Open

WebRequestContextImpl.getBaseUrl gives a full URL #80

willprice76 opened this issue Sep 29, 2017 · 0 comments
Labels
bug PR

Comments

@willprice76
Copy link
Contributor

In version 1.7 the links to social sharing, og metadata with the site URL and other functionality which makes links is all broken due to this, on pages other than the site root you get double URLs, like http://site/section/page/section/page
willprice76 added a commit to willprice76/dxa-web-application-java that referenced this issue Sep 29, 2017
@willprice76
Fixed getBaseUrl to return just the base URL, not the full URL - this…
f8fa40f 
… fixes a lot of issue with getFullUrl (which uses getBaseURL) see issue RWS#80
willprice76 added a commit to willprice76/dxa-web-application-java that referenced this issue Sep 29, 2017
@willprice76
Added base URL to urls in sitemap - see issue RWS#76 (note also requi…
27a55e7 
…res bug in webRequestContext.getBaseUrl() to be fixed - issue RWS#80)
@willprice76 willprice76 mentioned this issue Sep 29, 2017
Closed
rpannekoek pushed a commit that referenced this issue Oct 2, 2017
@RaimondKempees
Issue #80, Part I
38259fb
rpannekoek pushed a commit that referenced this issue Oct 2, 2017
@RaimondKempees
fixed issue #80. It is now possible to use intefaces or abstract clas…
f6a44cc 
…ses for both component link fields and embedded schema fields
rpannekoek pushed a commit that referenced this issue Jan 10, 2018
Merge pull request #80 in TSI/web-application-java from feature/TSI-2…
c639dd8 
…985 to develop

* commit 'c249e78d4160a2d9c9efb1770d70ea83b9c9fae2':
  TSI-2985 > Fixed readme file name, fixed typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willprice76 @rpannekoek