Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include pre-commit configuration #354

Closed
wants to merge 4 commits into from

Conversation

sbanoeon
Copy link
Contributor

No description provided.

@sbanoeon sbanoeon self-assigned this Nov 19, 2024
@sbanoeon sbanoeon linked an issue Nov 19, 2024 that may be closed by this pull request
5 tasks
@djs0109
Copy link
Contributor

djs0109 commented Nov 21, 2024

I saw that pre-commit is creating dependency problem with py38. Maybe we can include it as an optional dependency under extras_require

@djs0109
Copy link
Contributor

djs0109 commented Nov 26, 2024

@sbanoeon Could you also update the readme for setting up pre-commit for development env?

@sbanoeon sbanoeon requested a review from djs0109 December 3, 2024 14:38
@djs0109
Copy link
Contributor

djs0109 commented Dec 4, 2024

It seems like some of the pre-configured timeseries data is missing. I will have a check

@djs0109
Copy link
Contributor

djs0109 commented Dec 10, 2024

PR move into #364

@djs0109 djs0109 closed this Dec 10, 2024
@djs0109 djs0109 deleted the 341-introduce-pre-commit-hook-and-formatter branch December 10, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce pre-commit hook and formatter
2 participants