Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add extra config to make Unit model hashable #187

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

fix: add extra config to make Unit model hashable #187

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
884a7e6
chore: add extra config to make Unit model hashable
djs0109 Mar 3, 2023
4c2d94b
chore: added missing test
tstorek May 31, 2023
ae65579
chore: added missing test
tstorek May 31, 2023
19089c5
chore: add extra config to make Unit model hashable
djs0109 Mar 3, 2023
9a90df5
chore: added missing test
tstorek May 31, 2023
c39fb21
chore: added missing test
tstorek May 31, 2023
f25f84d
Merge remote-tracking branch 'origin/186-make-unit-model-hashable' in…
djs0109 Jun 1, 2023
99fa870
fix: compatible with python37
djs0109 Jun 2, 2023
9aa4bec
chore: add previous change in CHANGELOG.md
djs0109 Jun 2, 2023
8ba6364
chore: adapt code pattern
djs0109 Jun 2, 2023
4f70bf1
Merge branch 'master' into 186-make-unit-model-hashable
djs0109 Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/models/test_units.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def test_unit_model_caching(self):

self.assertEqual(unit.__hash__(), unit.__hash__())

@functools.lru_cache
@functools.lru_cache(maxsize=128)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't that the default anyway? I don't think that python 3.7 should fail because of this. https://docs.python.org/3.7/library/functools.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also wonder about that, but it actually fails with the error message:

TypeError: Expected maxsize to be an integer or None

btw, the python examples all give the maxsize explicitly.

def cache_unit(unit: Unit):
return Unit(name=unit.name)

Expand Down