Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification on claimable gift screen #72

Open
Lililashka opened this issue Feb 3, 2019 · 3 comments
Open

Notification on claimable gift screen #72

Lililashka opened this issue Feb 3, 2019 · 3 comments

Comments

@Lililashka
Copy link
Collaborator

Lililashka commented Feb 3, 2019

When viewing this screen from a non-web3 browser, user doesn’t get a helpful response once clicked on ‘claim gift’ button.

Reproduce this bug:

  1. Click on a claim link
  2. Open up a new screen with card preview and button ‘claim gift’
  3. Click on ‘claim gift’ button
  4. Nothing happens

Suggested solution:

  1. Add a pop-up note once users from non-web3 browser click claim gift button.
    “Oops! You can only claim gift using web3 browser. Install MetaMask, ImToken to get started.”

I’ll create this mock-up in figma and share it.

@chrismaree
Copy link
Collaborator

cool, thanks @Lililashka. I think this is due to portis providing a web3 client but if you dont create an account there is no unlocked wallet. this links to the other issue on defensive error handeling

@seichris
Copy link
Collaborator

seichris commented Feb 3, 2019

made designs for all situations, with and without portis #59. probably they could help

@seichris
Copy link
Collaborator

seichris commented Feb 3, 2019

Implemented this for now. Would disable the portis popup cause its still buggy (#73):

photo5384482065728252523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants