Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages when not passing required arguments for specific filetypes to generic read method #200

Open
bhazelton opened this issue Feb 3, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@bhazelton
Copy link
Member

This is a particular problem for votable files, where a number of column names must be specified. If you call the read_votable_file method, they are positional, required inputs. But when you call the generic read function they are defaulted to None and then you get a fairly unhelpful error message because it's trying to do work on a None object. These Nones should be caught in either the generic read method or the read_votable_file method (probably the latter).

@bhazelton bhazelton added the documentation Improvements or additions to documentation label Sep 21, 2023
@bhazelton bhazelton added this to the Next version milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant