From 8f0629dc45bdaefd5a5d14a596a21015916a2b3e Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 31 May 2024 11:33:44 +0000 Subject: [PATCH 1/2] Update rubocop requirement from >= 1.25, < 1.63 to >= 1.25, < 1.65 Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.25.0...v1.28.2) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] --- radius-spec.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/radius-spec.gemspec b/radius-spec.gemspec index 77ebc32..54fa742 100644 --- a/radius-spec.gemspec +++ b/radius-spec.gemspec @@ -32,7 +32,7 @@ Gem::Specification.new do |spec| spec.required_ruby_version = ">= 3.1" # rubocop:disable Gemspec/RequiredRubyVersion spec.add_runtime_dependency "rspec", "~> 3.7" - spec.add_runtime_dependency "rubocop", ">= 1.25", "< 1.63" + spec.add_runtime_dependency "rubocop", ">= 1.25", "< 1.65" spec.add_runtime_dependency "rubocop-rails", ">= 2.13", "< 2.22" spec.add_development_dependency "bundler", ">= 2.2.10" From ff678dac8e9ca7ad5c290b0be2341ba286c3a8e9 Mon Sep 17 00:00:00 2001 From: Corrie Leech Date: Wed, 2 Oct 2024 10:48:47 -0500 Subject: [PATCH 2/2] Tweaks Gemfile/gemspec for new offenses Rubocop now prefers add_dependency over add_runtime_dependency as the latter is considered soft-deprecated. It also wanted us to move the development dependencies to the Gemfile. Co-authored-by: Alex Stone Co-authored-by: James Nebeker Co-authored-by: JC Avena Co-authored-by: Jaxon Avena --- Gemfile | 5 +++++ radius-spec.gemspec | 9 +++------ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/Gemfile b/Gemfile index cab900f..31bedd3 100644 --- a/Gemfile +++ b/Gemfile @@ -7,6 +7,11 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" } # Specify your gem's dependencies in radius-spec.gemspec gemspec +group :development do + gem "bundler", ">= 2.2.10" + gem "rake", ">= 12.0", "< 14.0" +end + group :benchmark, optional: true do gem 'activesupport', require: false gem 'benchmark-ips', require: false diff --git a/radius-spec.gemspec b/radius-spec.gemspec index 54fa742..17f2d26 100644 --- a/radius-spec.gemspec +++ b/radius-spec.gemspec @@ -31,10 +31,7 @@ Gem::Specification.new do |spec| spec.required_ruby_version = ">= 3.1" # rubocop:disable Gemspec/RequiredRubyVersion - spec.add_runtime_dependency "rspec", "~> 3.7" - spec.add_runtime_dependency "rubocop", ">= 1.25", "< 1.65" - spec.add_runtime_dependency "rubocop-rails", ">= 2.13", "< 2.22" - - spec.add_development_dependency "bundler", ">= 2.2.10" - spec.add_development_dependency "rake", ">= 12.0", "< 14.0" + spec.add_dependency "rspec", "~> 3.7" + spec.add_dependency "rubocop", ">= 1.25", "< 1.65" + spec.add_dependency "rubocop-rails", ">= 2.13", "< 2.22" end