Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

Avoid "ugly" float number #23

Open
RaenonX opened this issue Sep 20, 2021 · 1 comment · Fixed by #24
Open

Avoid "ugly" float number #23

RaenonX opened this issue Sep 20, 2021 · 1 comment · Fixed by #24
Assignees
@RaenonX
Labels
Enhancements
Milestone
v1.1.0

Comments

@RaenonX
Copy link
Member

RaenonX commented Sep 20, 2021 •
edited
Loading

Avoid float numbers like this:

image

Current string formatter is .9g fixes this, but it does not fully solve the problem.

Related issue: K0lb3/UnityPy#69, RaenonX-DL/dragalia-site-front#309
@RaenonX RaenonX self-assigned this Sep 20, 2021
RaenonX added a commit that referenced this issue Sep 20, 2021
@RaenonX
Refactored json exporting implementations #23
471ecea 
Signed-off-by: RaenonX <[email protected]>
@RaenonX RaenonX closed this as completed Sep 20, 2021
@RaenonX RaenonX mentioned this issue Sep 20, 2021
Merged
@RaenonX RaenonX added this to the v1.1.0 milestone Sep 20, 2021
@RaenonX
Copy link
Member Author

RaenonX commented Sep 21, 2021

There are still numbers like this 0.349999994 exist. For example, bow's base normal attack of combo 1 (action ID 600000).

@RaenonX RaenonX reopened this Sep 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RaenonX RaenonX

Labels
Enhancements
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

v1.1.0 Release RaenonX-DL/dragalia-asset-downloader-2
1 participant
@RaenonX