Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra bench operations to consider #37

Open
AVVS opened this issue May 19, 2023 · 1 comment
Open

extra bench operations to consider #37

AVVS opened this issue May 19, 2023 · 1 comment

Comments

@AVVS
Copy link

AVVS commented May 19, 2023

Hi @RafaelGSS, do you think it might be useful to have Buffer.from / Buffer.toString() / string_decoder / TextDecoder / TextEncoder be present here - these are quite common operations and tracking improvements / regressions might be beneficial

@RafaelGSS
Copy link
Owner

Sure. We just need to make sure to compare _operations _ instead of APIs. For instance, comparing Buffer.from() vs new Buffer() should be acceptable. But comparing Buffer.from(shortString) with Buffer.from(longString) should be Node.js internal benchmark responsibility.

Feel free to send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants