Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rlpToMerkleNode should be static #80

Open
no2chem opened this issue Mar 28, 2019 · 1 comment
Open

rlpToMerkleNode should be static #80

no2chem opened this issue Mar 28, 2019 · 1 comment
Assignees
@SoujanyaPonnapalli

Comments

@no2chem
Copy link
Member

no2chem commented Mar 28, 2019

Currently, it seems that rlpToMerkleNode needs to have an instance of a merkle tree. Does it actually need any fields of the Merkle tree to work? It seems it shouldn't, so it should either be static, or just an exported function
@SoujanyaPonnapalli
Copy link
Member

rlpToMerkleNode : (rlpEncodedNode: Buffer) => MerklePatriciaTreeNode<V>
references the CachedMerklePatriciaTree class parameter V.

If rlpToMerkleNode is static, we will not be able to return a MerklePatriciaTreeNode<V>. We might have to return a generic MerklePatriciaTreeNode<any>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SoujanyaPonnapalli SoujanyaPonnapalli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@no2chem @SoujanyaPonnapalli