Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change required for AppCenter: Cannot install dependencies in post-install #2

Open
cassidyjames opened this issue Mar 25, 2021 · 0 comments

Comments

@cassidyjames
Copy link

cassidyjames commented Mar 25, 2021

Thanks for submitting Lroton to AppCenter! However, while reviewing the submission, we found an issue that needs to be resolved.

It looks like your app is installing dependencies system-wide in a post-install script, which means these packages would not be properly removed if your app is uninstalled. And more broadly, executing CLI commands with root privileges is not allowed in AppCenter apps.

system('sudo apt install -y openvpn dialog python3-pip python3-setuptools')
system('python3 -m pip install protonvpn-cli')

You'll need to add the packages to your app's Debian dependencies. For the protonvpn-cli being installed via pip, I believe the proper way to include this with your app would be to git submodule the project and install it in your app's data folder.

Once you've made the requested changes, create a new release on GitHub and re-submit it to the AppCenter Dashboard. As always, if you have any questions you can reply here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant