You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for submitting Lroton to AppCenter! However, while reviewing the submission, we found an issue that needs to be resolved.
It looks like your app is installing dependencies system-wide in a post-install script, which means these packages would not be properly removed if your app is uninstalled. And more broadly, executing CLI commands with root privileges is not allowed in AppCenter apps.
You'll need to add the packages to your app's Debian dependencies. For the protonvpn-cli being installed via pip, I believe the proper way to include this with your app would be to git submodule the project and install it in your app's data folder.
Once you've made the requested changes, create a new release on GitHub and re-submit it to the AppCenter Dashboard. As always, if you have any questions you can reply here.
The text was updated successfully, but these errors were encountered:
Thanks for submitting Lroton to AppCenter! However, while reviewing the submission, we found an issue that needs to be resolved.
It looks like your app is installing dependencies system-wide in a post-install script, which means these packages would not be properly removed if your app is uninstalled. And more broadly, executing CLI commands with root privileges is not allowed in AppCenter apps.
lroton/meson/post_install.py
Lines 12 to 13 in 9bbabeb
You'll need to add the packages to your app's Debian dependencies. For the protonvpn-cli being installed via pip, I believe the proper way to include this with your app would be to git submodule the project and install it in your app's data folder.
Once you've made the requested changes, create a new release on GitHub and re-submit it to the AppCenter Dashboard. As always, if you have any questions you can reply here.
The text was updated successfully, but these errors were encountered: