Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to create a new post in vue client #36

Closed
s-kris opened this issue Jun 4, 2018 · 11 comments
Closed

unable to create a new post in vue client #36

s-kris opened this issue Jun 4, 2018 · 11 comments
Assignees

Comments

@s-kris
Copy link
Collaborator

s-kris commented Jun 4, 2018

content is always empty and hence the following condition fails.

if (title.length && content.length) {

@Rajan
Copy link
Owner

Rajan commented Jun 4, 2018

The new post should be created only after there is some data. Clicking on the "New post" menu should only bring up the page. The creation happens when someone clicks on the "Save Post" button.

@Rajan
Copy link
Owner

Rajan commented Jun 4, 2018

I noticed that it's not really working locally somehow. Checking it.

@anurag-git
Copy link
Collaborator

I also tried not working. How to get debug logs. I don't see anything on console.

@Rajan
Copy link
Owner

Rajan commented Jun 4, 2018

The problem seems to be with editor binding with quill-editor tag. It is not reflecting in the vue data and hence it is failing.

@Rajan
Copy link
Owner

Rajan commented Jun 4, 2018

@anurag-git I just disabled the Image_Resize options and it works. The problem still lies with the image_resize options with our vue-quill-editor. Hence it is not yet solved.

Rajan added a commit that referenced this issue Jun 4, 2018
@Rajan
Copy link
Owner

Rajan commented Jun 4, 2018

@s-kris can you pull 3aa863f the new post should work.

@Rajan
Copy link
Owner

Rajan commented Jun 4, 2018

Root cause of this issues is #30

@s-kris
Copy link
Collaborator Author

s-kris commented Jun 4, 2018

It's working now.

@Rajan
Copy link
Owner

Rajan commented Jun 4, 2018

@anurag-git can you help with #30 without breaking newpost?

@anurag-git
Copy link
Collaborator

@Rajan Let me take new changes and then try. Can you explain what has to be done now, after my fix was not reverted(or not working as expected)

@Rajan
Copy link
Owner

Rajan commented Jun 4, 2018

If you look at editorOptions in Newpost.vue, we're having to comment resize options.

editorOption: {
        modules: {
          toolbar: [
            [{
              'size': ['small', false, 'large']
            }],
            ['bold', 'italic'],
            [{
              'list': 'ordered'
            }, {
              'list': 'bullet'
            }],
            ['link', 'image', 'video']
          ],
          history: {
            delay: 1000,
            maxStack: 50,
            userOnly: false
          },
          imageDrop: true
          // imageResize: {
          //   displayStyles: {
          //     backgroundColor: 'black',
          //     border: 'none',
          //     color: 'white'
          //   },
          //   modules: ['Resize', 'DisplaySize', 'Toolbar']
          // }
        }
      }

Because uncommenting it makes the editor fail. Need to understand 'Why' is this happening (look into ../main.js) and fix it.

@Rajan Rajan closed this as completed Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants