Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl6 error string is injected into path var #5

Open
zostay opened this issue Jan 2, 2020 · 2 comments
Open

perl6 error string is injected into path var #5

zostay opened this issue Jan 2, 2020 · 2 comments
Labels
bug Something isn't working transfer transfer from vim-perl6

Comments

@zostay
Copy link
Collaborator

zostay commented Jan 2, 2020

Migration of vim-perl#19 by @ghost

Description of issue

ftplugin/perl6.vim executes a shell command when it's invoked without checking v:shell_error:

        if &shellxquote != '"'
            let perlpath = system('perl6 -e  "@*INC.join(q/,/).say"')
        else
            let perlpath = system("perl6 -e  '@*INC.join(q/,/).say'")
        endif

Whatever this was originally for, it's not valid code in current versions of rakudo:

$ perl6 -e '@*INC.join(q/,/).say'
Dynamic variable @*INC not found
in block at -e line 1
...and this error text ends up in the value of :set path. I'm not sure what the original intent of this code was, but the thought that it's been executing random commands every time I open the editor on a perl6 file is a bit scary.

@zostay zostay added transfer transfer from vim-perl6 bug Something isn't working labels Jan 2, 2020
@zostay
Copy link
Collaborator Author

zostay commented Jan 2, 2020

I saw that when looking through the files initially and I have no idea what that is doing. I need to look at it more carefully and consider what should be done about.

@softmoth
Copy link

The offending code has been removed in #24, so I believe this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working transfer transfer from vim-perl6
Projects
None yet
Development

No branches or pull requests

2 participants