Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dd-nochildren not working as expected #55

Open
AzrielOmega opened this issue Feb 2, 2017 · 3 comments
Open

dd-nochildren not working as expected #55

AzrielOmega opened this issue Feb 2, 2017 · 3 comments
Labels

Comments

@AzrielOmega
Copy link

AzrielOmega commented Feb 2, 2017

Drag a item above dd-nochildren item just not show the placeholder, but if it have children by default and you drop it, it will become a children anyway.

@pjona pjona added the bug label Jun 21, 2017
@RomanBurunkov
Copy link
Contributor

Confirming the same behaviour.
So this option can't be used for forbiding to drop some element into another element in all cases, as it noticed at readme:

For example you can conditionally add .dd-nochildren to forbid dropping current element to some other elements for instance based on data-type of current element and other elements

@RomanBurunkov
Copy link
Contributor

RomanBurunkov commented Jun 26, 2017

I'm trying to implement this feature in another way, by adding beforeDragStop callback which able to cancel drag&drop if callback return false.

Looks like that in case of using dd-nochildren class, we have to add some additional conditions, but what if we need to cancel drop items in a root list from child? It sounds bit illogical to have no children if we already have them, IMHO.

@RomanBurunkov
Copy link
Contributor

Here is some conversation on it: dbushell/Nestable#143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants