Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Object Analyzer] oot skeletons can have only 1 limb, but the detection assumes there must be at minimum 2 #48

Open
Dragorn421 opened this issue Aug 20, 2021 · 1 comment

Comments

@Dragorn421
Copy link
Contributor

The issue

"Analyze Dlists" on object_ik partially fails to detect things

According to the actor Demo_Ik there's a skeleton at 0xC90 but Z64utils doesn't list it

(there may be more stuff missing not sure)

and Z64Utils outputs many Overlapping data warnings

Why (for the undetected skeleton issue, at least)

quoting Tharo from the zeldaret discord:

oh huh that's interesting, in the skeleton detection I made an assumption that every skeleton will have at least 2+ limbs, but that skeleton appears to have only 1

The fix may be simple but I didn't look at doing it, just opening this issue to avoid completely forgetting about it

@Thar0
Copy link
Contributor

Thar0 commented Aug 23, 2021

This is simple to fix but this may result in regressions caused by loosening the detection by removing this check, and we don't have a way to check for regressions right now beyond manually looking in a few object files which is not really sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants