Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very minor documentation issue in JsonDirectoryDataSource.js #4

Open
coderintherye opened this issue Mar 18, 2020 · 3 comments
Open

Very minor documentation issue in JsonDirectoryDataSource.js #4

coderintherye opened this issue Mar 18, 2020 · 3 comments

Comments

@coderintherye
Copy link

coderintherye commented Mar 18, 2020 •
edited
Loading

JsonDirectoryDataSource.js class comment on line 22 of current release says:

But should say

(At least as far as I can tell because FileDataSource looks to be a standalone class not extending another class)
coderintherye added a commit to coderintherye/datasource-file that referenced this issue Mar 18, 2020
@coderintherye
RanvierMUD#4 Fix minor documentatoin issue of what class this extends
84c8d2a
@coderintherye coderintherye mentioned this issue Mar 18, 2020
Open
@NuSkooler
Copy link

What is this SqliteDataSource you speak of?

@coderintherye coderintherye changed the title Very minor documentation issue in SqliteDataSource.js Very minor documentation issue in JsonDirectoryDataSource.js Mar 26, 2020
@coderintherye
Copy link
Author

@NuSkooler apologies the title was incorrect but the description noted it correct, JsonDirectoryDataSource.js

@NuSkooler
Copy link

@coderintherye Damn! I have that on my TODO list, was hoping someone had TODONE already!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coderintherye @NuSkooler