Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websocket-networking wss.js uses a static port instead of config #3

Open
ProjectStickman opened this issue Aug 2, 2019 · 2 comments
Open

Websocket-networking wss.js uses a static port instead of config #3

ProjectStickman opened this issue Aug 2, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@ProjectStickman
Copy link

At line 15:

const wss = new WebSocket.Server({ port: 4001 });

Instead there should be a wsport variable in the config that gets loaded in.
@shawncplus shawncplus transferred this issue from RanvierMUD/docs Aug 2, 2019
@nahilep
Copy link

nahilep commented Aug 2, 2019

There will be a hacktoberfest again, this looks like a help wanted hacktoberfest label :)

@stennie stennie self-assigned this Oct 25, 2020
@stennie
Copy link
Contributor

stennie commented Oct 25, 2020

This should also support the PORT environment variable for deployment on Heroku: https://devcenter.heroku.com/articles/runtime-principles#web-servers

@stennie stennie mentioned this issue Oct 25, 2020
Closed
@stennie stennie added the enhancement New feature or request label Oct 25, 2020
@stennie stennie removed their assignment Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stennie @ProjectStickman @nahilep