From ce523c8900fc117afaa780ad382158cd31d5f190 Mon Sep 17 00:00:00 2001 From: github-actions Date: Sun, 29 Oct 2023 21:48:31 +0000 Subject: [PATCH] Update to 2 in STEP and README.md --- .github/steps/-step.txt | 2 +- README.md | 34 +++++++++++++++------------------- 2 files changed, 16 insertions(+), 20 deletions(-) diff --git a/.github/steps/-step.txt b/.github/steps/-step.txt index d00491f..0cfbf08 100644 --- a/.github/steps/-step.txt +++ b/.github/steps/-step.txt @@ -1 +1 @@ -1 +2 diff --git a/README.md b/README.md index a710e36..7568d4c 100644 --- a/README.md +++ b/README.md @@ -14,32 +14,28 @@ _Collaborate and work together on GitHub._ -## Step 1: Open a pull request +## Step 2: Assign yourself -_Welcome to "Review pull requests"! :wave:_ +_Great job opening that pull request! :wave:_ -Let's get started by opening a pull request. +**What is a _pull request review_?**: Reviewing a pull request is an opportunity to examine another contributor's changes and give them feedback. It's an awesome opportunity to learn more about how the project works and how others solve problems. -**What is a pull request?**: Collaboration happens on a pull request. The pull request shows the changes in your branch to other people. This pull request is going to keep the changes you just made on your branch and propose applying them to the `main` branch. +The best way to get a review is to ask for one. On GitHub, you can ask someone to review a pull request by assigning them as a reviewer or assignee. If you are not ready for review, consider [creating a draft pull request](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request) instead. -### :keyboard: Activity: Create a pull request +### :keyboard: Activity: Assign yourself -1. Click on the **Pull requests** tab in your repository. -2. Click **New pull request**. -3. In the **base:** dropdown, make sure **main** is selected. -4. Select the **compare:** dropdown, and click `update-game`. -5. Click **Create pull request**. -6. Enter a title for your pull request: `Update the game over message`. -7. Enter a description for your pull request: `Update the game over message so people know how to play again!` -8. Click **Create pull request**. -9. Wait about 20 seconds then refresh this page (the one you're following instructions from). [GitHub Actions](https://docs.github.com/en/actions) will automatically update to the next step. +1. Open the pull request you just created. +1. Under **Assignees** on the right side of the screen, add yourself. + + Because you created the pull request, you can't assign yourself as a reviewer, but feel free to assign a friend as a reviewer instead to see how it works :smile: + +1. Wait about 20 seconds then refresh this page (the one you're following instructions from). [GitHub Actions](https://docs.github.com/en/actions) will automatically update to the next step.