Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Don't close the whole app at any error. #163

Open
TheK0tYaRa opened this issue Feb 5, 2022 · 2 comments
Open

[Feature Request] Don't close the whole app at any error. #163

TheK0tYaRa opened this issue Feb 5, 2022 · 2 comments
Labels
feature-request New feature or request

Comments

@TheK0tYaRa
Copy link

Is your feature request related to a problem? Please describe.
It should not crash if the path is invalid. For example, if "Override Exe" is set to explorer /desktop=anyname,1920x1090 cmd /c Torchlight2.exe

Describe the solution you'd like
There should be a verbose error that doesn't crash the app instead.

Describe alternatives you've considered
Or at least a non-verbose one that says what field was mis-filled.

@TheK0tYaRa TheK0tYaRa added the feature-request New feature or request label Feb 5, 2022
@Dummerle
Copy link
Collaborator

Dummerle commented Feb 5, 2022

Do you have an exact error message?

@Dummerle
Copy link
Collaborator

Dummerle commented Feb 5, 2022

I pushed a fix, which shows a message, if the path does not exist.

I have to think about the feature request, because, if the app crashes, there might be some issues. After a restart will everything work.

You better use wrapper to set explorer as executable. I think it needs a better explanation in ui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants