stopovers; added airports.csv #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JEM-Mosig
suggested changes
Jan 30, 2020
There was a problem hiding this comment.
@evgeniiaraz Great that you got this to work! I just have a few comments. Also, could you please add some test stories?
actions.py
Outdated
| message = f"The trip from {departure_airport} ({departure_iata}) to {destination_airport} ({destination_iata}) "\ | ||
| f"via {stopover_airport} ({stopover_iata}) emits {co2_in_tons[2]+co2_in_tons[3]:.1f} of CO2. " \ | ||
| f"The first leg emits {co2_in_tons[0]} of CO2. " \ | ||
| f"The second leg emits {co2_in_tons[1]} of CO2." \ |
There was a problem hiding this comment.
I don't think users would want to know these specifics. You can leave this out for now.
There was a problem hiding this comment.
I added it only because Alan proposed it in the initial issue. Should I remove it? or reformat the message somehow?
There was a problem hiding this comment.
It's not really important. You may choose either way :)
JEM-Mosig
reviewed
Feb 7, 2020
| }.get(unit) | ||
|
|
||
| if not kilos_per_unit: | ||
| raise ValueError(f"Unknown unit: '{unit}'") | ||
|
|
||
| unit_string = "kg" if unit == "kilograms" else "tons" | ||
|
|
||
| co2 = f"{ceil(10 * co2_kg / kilos_per_unit) * 0.1:.1f} {unit_string}" | ||
| co2 = (f"{ceil(10 * co2_kg / kilos_per_unit) * 0.1:.1f} {unit_string}",) |
actions.py
Outdated
| def clarify_stopover(departure, stopover, destination, dispatcher, tracker): | ||
| """ | ||
| Informs the user about the discovered stopover trip; | ||
| Appears right before the offset calculations |
actions.py
Outdated
| Returns: | ||
| a boolean flag of whether a connecting flight was found; | ||
| if it was found: | ||
| a tuple of ((departure airport name, departure IATA code), (stopover airport name, stopover IATA code), |
There was a problem hiding this comment.
Optional: You could use a named tuple here, for more clarity.
…the clarification message to reduce the readload
Intent Cross-Validation Results (5 folds)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10:
The only thing which I'll give another try a bit later today is the double message when giving the second route straight up.
Thanks a lot! and I hope it's not too scary :)